react-jsonschema-form icon indicating copy to clipboard operation
react-jsonschema-form copied to clipboard

Published 20 hours ago • verified publisher icon rjsf-team

Feature/Enhance the color widget

Open nathanNguyenQ1 opened this issue 3 years ago • 2 comments

Reasons for making this change

Currently, the color widget is not responsive enough for user interaction, it doesn't show the color code until the user clicks to open the palette color. The new UI allows users to look and feel the interaction.

UI Before: image

UI After: image

  • User can view, edit, or paste color code directly without open palette color.
  • User can open palette color to pick a color and the value will display on the text box

Checklist

  • [x] I'm updating documentation
  • [x] I'm adding or updating code
    • [x] I've added and/or updated tests
    • [x] I've updated docs if needed
    • [x] I've updated the changelog with a description of the PR
  • [x] I'm adding a new feature
    • [ ] I've updated the playground with an example use of the feature

nathanNguyenQ1 avatar Jan 11 '22 04:01 nathanNguyenQ1

@nathanNguyenQ1 Can you rebase and deal with conflicts?

heath-freenome avatar Mar 11 '22 17:03 heath-freenome

Hi @epicfaace and @heath-freenome I have rebased and fix conflict in merge request. Could you please review it. Thank you.

nathanNguyenQ1 avatar Jul 13 '22 03:07 nathanNguyenQ1

@nathanNguyenQ1 If you revert all of the package*.json changes (when we release we'll do all that) and deal with the conversion of ColorWidget to typescript, I'm willing to add this to the v5 beta

heath-freenome avatar Aug 29 '22 16:08 heath-freenome

@nathanNguyenQ1 You'll have to update the snapshots for many of the theme tests. Also, Please update the CHANGELOG.md for the next, unpublished beta release

heath-freenome avatar Sep 07 '22 16:09 heath-freenome

@nathanNguyenQ1 You'll have to update the snapshots for many of the theme tests. Also, Please update the CHANGELOG.md for the next, unpublished beta release

Hi @heath-freenome, I updated the snapshots and CHANGELOG.md.

nathanNguyenQ1 avatar Sep 08 '22 04:09 nathanNguyenQ1

@nathanNguyenQ1 I just tried this with the other themes and most of them do not look so good. I'm leaning towards reverting this PR until the other themes are fixed up as well. Is that something you are willing to do?

heath-freenome avatar Sep 08 '22 07:09 heath-freenome

@nathanNguyenQ1 After sleeping on it, I am definitely going to revert this. I can help you understand what needs to be done to get things working on the other themes if you'd like. Reach out on the discord channel

heath-freenome avatar Sep 08 '22 17:09 heath-freenome