react-jsonschema-form
react-jsonschema-form copied to clipboard
Fix for ui:options label & description
Reasons for making this change
There are many bugs describing the problem with the current code ignoring some settings from uiSchema; namely
- ui:title,
- ui:description
- ui:options
- label:
- title:
- description:
- label:
This changeset fixes above problems for all fields, array fields and object fields. Labels are hidden when the ui:options {label: false} is provided as well as title and description fields from ui:options are applied as per the documentation.
If this is related to existing tickets, include links to them as well. Use the syntax fixes #2535
.
Checklist
- [ ] I'm updating documentation
- [x] I've checked the rendering of the Markdown text I've added
- [x] I'm adding or updating code
- [x] I've added and/or updated tests
- [ ] I've updated docs if needed
- [ ] I'm adding a new feature
- [ ] I've updated the playground with an example use of the feature
Note
- No documentation updates are required as this is a bug fix and aligns the expected behavior with documented behavior.
Screenshots


Tests passing after the code change
Tests failing before code change
https://pastebin.com/QE2a9jqv
@epicfaace I have made the changes based on your review. Let me know if you need anything else in order to merge this.
LGTM
@newt10 @bejito What is the status with this ticket?
@newt10 With the conversion to typescript in v5, I was wondering if you had time to refactor this onto the latest changes in master?