rjsf-team
Warning: Using UNSAFE_componentWillReceiveProps in strict mode is not recommended
Hi!
I have an old bug see here but i'm with the last version.
I know that the warning is not raised in production but normally this bug was fixed in the 2.0 version, isn't it ?
I'm only reusing one Form component and only change data and uischema for each schema I have in my multistep form.
Description
index.js:1 Warning: Using UNSAFE_componentWillReceiveProps in strict mode is not recommended and may indicate bugs in your code. See https://fb.me/react-unsafe-component-lifecycles for details.
- Move data fetching code or side effects to componentDidUpdate.
- If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
Please update the following components: Form
Version
react: 16.13.1 @rjsf/core: 2.0.1
Cheers, Yu.
Yes, we still use UNSAFE_componentWillReceiveProps in 2.0 -- the only thing that was fixed was removing a few instances of this method, and mostly just renaming componentWillReceiveProps -> UNSAFE_ componentWillReceiveProps. If you'd like to help with refactoring to remove it, that would be very much appreciated!
It doesn't look like it yet. More info on a fix:
https://reactjs.org/docs/react-component.html#unsafe_componentwillreceiveprops https://itnext.io/react17-or-how-to-get-rid-of-componentwillreceiveprops-c91f9a6f6f03
Hi, I found the same warning.
When can the checkin be expected in a release and will it fix this Issue so that the warning disappears?
this is the commit with the fix https://github.com/mrjuan1/react-jsonschema-form/commit/0dd427d5368db4ca9458c77fca79887d48a0d748
this is the commit with the fix mrjuan1@0dd427d
Maybe I’m being dumb, but I can’t see a PR for this (neither open nor closed)?
@jimmycallin has a slightly more complex PR https://github.com/rjsf-team/react-jsonschema-form/pull/2010 that does this, though maybe https://github.com/mrjuan1/react-jsonschema-form/commit/0dd427d5368db4ca9458c77fca79887d48a0d748 would just work as a simpler solution instead? What do you think @jimmycallin ?
"slightly more complex" is surely an understatement. If it works, I'm happy! I'll see if I can figure out why I thought the refactorings were necessary.
Ok, I just looked into the commit and it won't work unfortunately, for the reasons that caused me to introduce the necessary refactorings.
On line 45 you can see that it calls a class method using this.getStateFromProps. Since it's a static method, this is not allowed. Once you start to break out all logic related to this.getStateFromProps, you will probably end up with a PR similar to my #2010.
up? We now have react 18 out and this issue popped up in a previous major release so it would be neat to fix it.
