react-jsonschema-form icon indicating copy to clipboard operation
react-jsonschema-form copied to clipboard

Fix anyof and oneof inside additional properties.

Open sempostma opened this issue 5 years ago • 5 comments

Reasons for making this change

oneOf and anyOf properties are not working properly inside additional properties.

Checklist

  • [ ] I'm updating documentation
  • [x] I'm adding or updating code
    • [x] I've added and/or updated tests
    • [ ] I've updated docs if needed
  • [ ] I'm adding a new feature
    • [ ] I've updated the playground with an example use of the feature

sempostma avatar Feb 11 '20 21:02 sempostma

@epicfaace I have added the tests in https://github.com/rjsf-team/react-jsonschema-form/pull/1588/commits/9be4b1a4d15ba9afa980045a46c5cc6e10b217a1.

sempostma avatar Feb 12 '20 17:02 sempostma

@epicfaace Is this still awaiting review?

sempostma avatar Apr 21 '20 19:04 sempostma

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please leave a comment if this is still an issue for you. Thank you.

stale[bot] avatar May 25 '22 09:05 stale[bot]

This is stil an issue and applying this fix using patch-package seems to reliably resolve it (at least in my use case and for @rjsf/core 4.1.1)

memalloc avatar May 25 '22 09:05 memalloc

@memalloc Given the changes in v5 beta, the code here needs refactoring. Is this something you are willing to do?

heath-freenome avatar Sep 07 '22 18:09 heath-freenome

Closing this PR as it is reimplemented in #3435

heath-freenome avatar Feb 06 '23 03:02 heath-freenome