Rafał Jęczalik

Results 122 comments of Rafał Jęczalik

> Would you welcome a PR where I add some of the information, that wasn't obvious to me, to the comments on the windows constants? > This is rather a...

Hey @timesking, thanks for reporting. What platform are you using? > c := make(chan notify.EventInfo, 1) You may want to use a bigger buffer here if you expect larger volume...

You need to provide me with full example, there might be too many loose ends (blocking send on `bus`?). (hint: for debug logging you just compile your cmd with `-tags...

Sure, create a chan per a directory to watch and fan in all the events to the single channel.

> Then there is all the goroutines required to fan all of the channels into a single channel... The implementation on the library side would be roughly the same, since...

> What about having the library allow you to stop watching based on the directory string That perfectly makes sense. Adding to v2 api todo-list.

@veqryn I'm a bit skeptic about using uuid, it would mean maintaining yet another watcher mapping, where two mappings already exist - channel to watcher and path to watcher. I'd...

Ideally we'd want to make it backward-compatible. Besides path to watcher mapping is going to stay, since the implementation uses tree-based directory lookup.

It can stay opened, so we can keep track of this. Thanks! 😄

@lsegal Actually it is a bug in this case. However unusual, to watch the whole drive, it should be working. Thanks for debugging this!