Rafał Jęczalik

Results 122 comments of Rafał Jęczalik

> any thoughts / additions to the above? I'd love to have klient reworked first, in particular the way we handle passing configuration to it - right now we inject...

@cihangir Let's move the discussion to https://github.com/koding/koding/issues/8965. I've addressed your concerns plus added an explanation of the problem. I was listing problems from top of my head, so I may...

> Would it be possible to pass args to tell interfacer which package name to use in this scenario? I think interfaces should be smart enough to read the actual...

Overall this is good idea, I am not sure go/types gives you the name of the arguments in a typed func def. This needs to be researched.

Related https://github.com/rjeczalik/interfaces/issues/37 https://github.com/rjeczalik/interfaces/issues/32

The code responsible for reading package names in typed defs should be improved. Related https://github.com/rjeczalik/interfaces/issues/37

> Is this by design/unavoidable or is this a bug? There are no optimization in the interfacer at all, like caching loaded packages etc. Definitely it can be improved performance-wise.

I removed the outrageous "under active development" note from the readme. Thanks for reporting!

I bumped into this issue as well, as a workaround I'm calling `_flush()` each write on the encode-stream. Would extending `createEncodeStream` with optional `options` argument make sense? The API would...