rizin icon indicating copy to clipboard operation
rizin copied to clipboard

meson: Enable fdopen support detection for libzip

Open IndAlok opened this issue 2 weeks ago • 3 comments

Your checklist for this pull request

  • [ ] I've read the guidelines for contributing to this repository.
  • [ ] I made sure to follow the project's coding style.
  • [ ] I've documented every RZ_API function and struct this PR changes.
  • [ ] I've added tests that prove my changes are effective (required for changes to RZ_API).
  • [ ] I've updated the Rizin book with the relevant information (if needed).
  • [ ] I've used AI tools to generate fully or partially these code changes and I'm sure the changes are not copyrighted by somebody else.

Detailed description

Add checks for fdopen (POSIX/Linux/macOS) and _fdopen (Windows) to enable fdopen support in libzip. This fixes compilation warnings about unused variables in zip_fdopen.c. Proposed initially in #5571.

Test plan

...

Closing issues

...

IndAlok avatar Dec 08 '25 01:12 IndAlok

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 46.59%. Comparing base (a8e2ff1) to head (54a86c7). :warning: Report is 43 commits behind head on dev.

Additional details and impacted files

see 14 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a8e2ff1...54a86c7. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 08 '25 02:12 codecov[bot]

They are still in the gcc logs:

[692/2423] Compiling C object subprojects/libzip-1.11.3/liblibzip.a.p/lib_zip_fdopen.c.o
../subprojects/libzip-1.11.3/lib/zip_fdopen.c: In function ‘zip_fdopen’:
../subprojects/libzip-1.11.3/lib/zip_fdopen.c:47:22: warning: unused variable ‘error’ [-Wunused-variable]
   47 |     struct zip_error error;
      |                      ^~~~~
../subprojects/libzip-1.11.3/lib/zip_fdopen.c:46:19: warning: unused variable ‘src’ [-Wunused-variable]
   46 |     zip_source_t *src;
      |                   ^~~
../subprojects/libzip-1.11.3/lib/zip_fdopen.c:45:12: warning: unused variable ‘za’ [-Wunused-variable]
   45 |     zip_t *za;
      |            ^~
../subprojects/libzip-1.11.3/lib/zip_fdopen.c:44:11: warning: unused variable ‘fp’ [-Wunused-variable]
   44 |     FILE *fp;
      |           ^~
../subprojects/libzip-1.11.3/lib/zip_fdopen.c:43:9: warning: unused variable ‘fd’ [-Wunused-variable]
   43 |     int fd;
      |         ^~
[693/2423] Compiling C object subprojects/libzip-1.11.3/liblibzip.a.p/lib_zip_file_add.c.o
[694/2423] Compiling C object subprojects/libzip-1.11.3/liblibzip.a.p/lib_zip_file_error_clear.

Rot127 avatar Dec 09 '25 15:12 Rot127

this should probably be fixed by submitting a PR to libzip.

wargio avatar Dec 10 '25 08:12 wargio

Was merged as part of another PR: https://github.com/rizinorg/rizin/pull/5571

notxvilka avatar Dec 20 '25 06:12 notxvilka