rizin icon indicating copy to clipboard operation
rizin copied to clipboard

Add pfa and ica commands to replace removed pf* and ic* functionality

Open Eshaan-byte opened this issue 3 weeks ago • 1 comments

Your checklist for this pull request I've read the guidelines for contributing to this repository.

I made sure to follow the project's coding style.

-I've documented every RZ_API function and struct this PR changes.

-I've added tests that prove my changes are effective (required for changes to RZ_API).

-I've updated the Rizin book with the relevant information (if needed).

Detailed description Adds pfa and ica commands to replace removed pf and ic functionality after PR #5540. -pfa : Apply format string at current offset (replaces .pf) -ica: Load classes into type database (replaces .ic)

Both commands execute directly in C instead of generating rizin commands. Test plan Fixed 6 broken tests in test/db/cmd/cmd_tc by replacing .ic with ica. Tests will be verified by CI.

Closing issues Closes #5560

Eshaan-byte avatar Dec 05 '25 15:12 Eshaan-byte

Codecov Report

:x: Patch coverage is 50.00000% with 18 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 46.58%. Comparing base (2fa0c2c) to head (60af943). :warning: Report is 56 commits behind head on dev.

Files with missing lines Patch % Lines
librz/core/cbin.c 64.00% 3 Missing and 6 partials :warning:
librz/core/cmd/cmd_print.c 0.00% 8 Missing :warning:
librz/core/cmd/cmd_info.c 66.66% 0 Missing and 1 partial :warning:
Additional details and impacted files
Files with missing lines Coverage Δ
librz/core/cmd/cmd_info.c 56.53% <66.66%> (+0.06%) :arrow_up:
librz/core/cmd/cmd_print.c 43.66% <0.00%> (-0.09%) :arrow_down:
librz/core/cbin.c 66.14% <64.00%> (+0.46%) :arrow_up:

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2fa0c2c...60af943. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 05 '25 16:12 codecov[bot]

AI slop

notxvilka avatar Dec 20 '25 06:12 notxvilka