rizin icon indicating copy to clipboard operation
rizin copied to clipboard

Replace `.pf*` with C equivalent and fix `tc` tests.

Open wargio opened this issue 1 month ago • 2 comments

Due the changes in #5540 several tests in test/db/cmd/cmd_tc have been marked as broken due pf not producing anymore valid commands to apply flags at a given offset.

Before that PR, you could call pf* to generate all the needed commands to define the structure manually and with the help of . (i.e. eval) you could do .pf* foo @ 0x1234 to define the structure foo at address 0x1234.

The idea is a similar command from the pf command group to define the structure at the current offset, so the user could do pf<new cmd> @ 0x1234 to achieve the same thing.

See librz/type/format.c code for more details.

wargio avatar Nov 29 '25 13:11 wargio

I'd like to work on this issue. I'll:

  1. Review the changes in #5540 to understand what broke
  2. Implement a new pf command to define structures at the current offset
  3. Update the broken tests in test/db/cmd/cmd_tc to use the new command
  4. Ensure the new implementation provides equivalent functionality to the old pf

Could you assign this to me?

Eshaan-byte avatar Dec 05 '25 01:12 Eshaan-byte

Could you assign this to me?

Just send a PR. We will not assign until then.

notxvilka avatar Dec 05 '25 09:12 notxvilka