rizin icon indicating copy to clipboard operation
rizin copied to clipboard

Add s390x debug support and fix code in debug module

Open well-mannered-goat opened this issue 5 months ago • 2 comments

Your checklist for this pull request

  • [ ] I've read the guidelines for contributing to this repository.
  • [ ] I made sure to follow the project's coding style.
  • [ ] I've documented every RZ_API function and struct this PR changes.
  • [ ] I've added tests that prove my changes are effective (required for changes to RZ_API).
  • [ ] I've updated the Rizin book with the relevant information (if needed).

Detailed description

  • removed a redundant file for linux arm64
  • have separated some functions which helps in understanding code since the native debugger code is #includeed into the debug_native.c
  • added a linux-s390x file for native plugin
  • added dwarf mapping for sysz architecture
  • added register progile for 64 bit s390x and fixed s390 32 bit. ( i have used all the registers that ptrace provides access to).
  • right now I just want to check if I am not breaking something

Please ignore the changes in .gitignore and meson.build, I have made those changes so that I can properly build and install to my VM. Hopefully disabling PCRE2 JIT doesnt break other sysz tests

Test plan

...

Closing issues

...

well-mannered-goat avatar Jul 14 '25 14:07 well-mannered-goat

Please move the non-s390x stuff into a separated PR after you are done here.

Rot127 avatar Jul 21 '25 10:07 Rot127

Codecov Report

:x: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 44.64%. Comparing base (22089ed) to head (575b7bf). :warning: Report is 265 commits behind head on dev.

Files with missing lines Patch % Lines
librz/arch/dwarf_process.c 0.00% 1 Missing and 1 partial :warning:
Additional details and impacted files
Files with missing lines Coverage Δ
librz/debug/p/native/linux/linux_debug.c 38.66% <ø> (ø)
librz/include/rz_types.h 30.76% <ø> (ø)
librz/arch/dwarf_process.c 61.26% <0.00%> (-0.09%) :arrow_down:

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 22089ed...575b7bf. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jul 21 '25 14:07 codecov[bot]