rizin icon indicating copy to clipboard operation
rizin copied to clipboard

move old debugger

Open well-mannered-goat opened this issue 7 months ago • 1 comments

Your checklist for this pull request

  • [x] I've read the guidelines for contributing to this repository.
  • [x] I made sure to follow the project's coding style.
  • [ ] I've documented every RZ_API function and struct this PR changes.
  • [ ] I've added tests that prove my changes are effective (required for changes to RZ_API).
  • [ ] I've updated the Rizin book with the relevant information (if needed).

Detailed description

  • Moved the debugger code into the debug/old/ directory.
  • Added use_old_debugger meson option which is by default true
  • Refactored wherever old debugger plugins were used

Test plan

...

Closing issues

...

well-mannered-goat avatar May 22 '25 10:05 well-mannered-goat

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 44.89%. Comparing base (5b131b6) to head (758fe90). Report is 3 commits behind head on dev.

Additional details and impacted files
Files with missing lines Coverage Δ
librz/core/cmd/cmd_debug.c 22.32% <ø> (ø)
librz/debug/old/bp.c 56.80% <ø> (ø)
librz/debug/old/bp_io.c 70.00% <ø> (ø)
librz/debug/old/bp_traptrace.c 3.88% <ø> (ø)
librz/debug/old/bp_watch.c 50.00% <ø> (ø)
librz/debug/old/ddesc.c 30.76% <ø> (ø)
librz/debug/old/debug.c 43.99% <ø> (ø)
librz/debug/old/desil.c 38.54% <ø> (ø)
librz/debug/old/dmap.c 56.89% <ø> (ø)
librz/debug/old/dreg.c 48.64% <ø> (ø)
... and 36 more

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5b131b6...758fe90. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 22 '25 13:05 codecov[bot]