cutter icon indicating copy to clipboard operation
cutter copied to clipboard

Scrolling of Disassembly widget is noticiably slower than in Graph widget

Open XVilka opened this issue 2 years ago • 10 comments

If we open function complex enough, e.g. with 40 basic blocks in Cutter, scrolling of it in Disassembly language lags significantly, while technically the same data in Graph widget can be scrolled way, way faster once rendered.

XVilka avatar Aug 04 '23 05:08 XVilka

It looks like closed by https://github.com/rizinorg/cutter/commit/8574f0b0e42a1f0d12599548d9907a56dd236182 - cannot reproduce it anymore.

XVilka avatar Feb 23 '24 12:02 XVilka

I can still reproduce this on 2.3.4

k1gen avatar Oct 09 '24 07:10 k1gen

@k1gen please provide more details. Does it happen on all files or just some particular ones?

XVilka avatar Oct 09 '24 08:10 XVilka

@XVilka I have tried five binaries of different sizes (16kb to 116mb) - the disassembly view is extremely laggy in all of them: Screencast from 2024-10-09 14-19-39.webm the graph view is okay

k1gen avatar Oct 09 '24 12:10 k1gen

@k1gen Which OS and CPU do you use? Do you see anything in the logs? If it is a less common OS it might be again a PCRE2 JIT problem.

Rot127 avatar Oct 09 '24 14:10 Rot127

@Rot127 I have an i5-8350U. I use NixOS. It's pretty common nowadays, so I don't think this is an OS problem.

k1gen avatar Oct 09 '24 14:10 k1gen

Then you are likely affected by https://github.com/rizinorg/cutter/issues/3328

Sorry, I still have not taken the time to set up a workable NixOS VM. Do you build Cutter by yourself? If yes, you can try to use this patch: https://github.com/rizinorg/cutter/issues/3328#issuecomment-2066107922. Otherwise I investigate it tomorrow.

Rot127 avatar Oct 09 '24 15:10 Rot127

I didn't build it myself. When I need Cutter, I enter a nix shell with nix-shell -p "(cutter.withPlugins (ps: with ps; [ rz-ghidra sigdb ]))". I am not a very experienced NixOS user, I do not know how to apply patches to binaries here. I would really appreciate your help.

k1gen avatar Oct 09 '24 17:10 k1gen

@k1gen I am sorry, but I also did not managed to build it in a reasonable time. I hope the original contributor will give some feedback on it: https://github.com/NixOS/nixpkgs/pull/347699

Rot127 avatar Oct 10 '24 09:10 Rot127

@k1gen Did https://github.com/NixOS/nixpkgs/pull/347699 fix it for you?

Rot127 avatar Oct 21 '24 16:10 Rot127