darts-clone-python icon indicating copy to clipboard operation
darts-clone-python copied to clipboard

add README note for "ImportError: DLL load failed"

Open jiang7369 opened this issue 6 years ago • 4 comments

I encountered this problem when trying to start a background project using ginza.

After exploring(ginza->SudachiPy->darts-clone), I found that this package has a dll error.

I don't know what dll is missing, I installed the latest supported Visual C++ redistributable packages with a try mentality and solved the problem. I think we can add a note for it in README.md.

jiang7369 avatar Mar 19 '20 14:03 jiang7369

Could you tell me your os and python version to reproduce the error? Thank you @jiang7369 for reporting the problem.

rixwew avatar Mar 20 '20 05:03 rixwew

os: Windows10 python: 3.6.8

But this may have nothing to do with the version. Windows 10 without the VC++ package can reproduce it, I think.

jiang7369 avatar Mar 20 '20 13:03 jiang7369

Thank you @jiang7369 I reproduced it and confirmed that bundling some vc++ dll like pandas solve the error. https://github.com/pandas-dev/pandas/pull/21321

We should decide whether to bundle vc++ dll or not. I'd like to get your thoughts on this issue. @hiroshi-matsuda-rit @toshi-saito

rixwew avatar Mar 22 '20 09:03 rixwew

@jiang7369 @rixwew Thanks for reporting. In fact, I've never encountered this error while installing GiNZA on some of the Windows 10 environments. But we should solve this error with the work around of pandas, I think. Please check the license of the DLL files to be added to the whl packages and make sure that the license is compatible with darts-clone-python's one.

hiroshi-matsuda-rit avatar Mar 24 '20 17:03 hiroshi-matsuda-rit