svelte-template-hot icon indicating copy to clipboard operation
svelte-template-hot copied to clipboard

Published 20 hours ago • verified publisher icon rixo

Useless const spa?

Open frederikhors opened this issue 3 years ago • 3 comments

Now we have this, but where it's used?

const spa = false

frederikhors avatar Oct 18 '20 12:10 frederikhors

It was used to add the --single flag to sirve, in the custom server plugin that has changed during last merge.

You need that for non hashed-based client side routing. It's an issue that comes quite often with people that want to do SPAs. The point was to help with this situation.

We can probably remove this now. What do you think?

How is the SPA hard point addressed in the official template currently?

rixo avatar Oct 18 '20 12:10 rixo

Do you refer to this? https://github.com/sveltejs/template/pull/116

I think we can enlight this in Readme and remove that const.

I'm using --single in serve function.

frederikhors avatar Oct 18 '20 13:10 frederikhors

Yes that's what I'm referring to. Apparently unsolved upstream... I guess we can just drop the const for now and follow suit if they take any decision :shrug:

rixo avatar Oct 21 '20 21:10 rixo