Šimon Kandráč

> Making the boolean type aware of UNSIGNED is a terrible idea, sorry. I know, it's an ugly fix, you don't need to be sorry. > Shouldn't your problem go...

> I don't get this part, sorry. Shouldn't you be able to support custom widths in your custom TINYINT type? Yes, I want the default (3), but if I do...

The change would be also backwards compatible, and I think that author intended to change MariaDB as well. I think that in all MySQL/MariaDB versions it's not required to define...

> You've limited inferring nullability to attribute mapping while type inference works with any driver. Why's that? It seemed like easier option to start with, and I didn't know codebase...

I did a rewrite and now it's working for all drivers via `Configuration::setInferPhpNullability`, because it's saved only on `ClassMetadata` level, and attribute driver can access it and if it's enabled,...

I rebased it onto 3.4.x, it's ready for review, one thing I'm not sure about is to how to treat variables without type, I think it will be better to...

> > one thing I'm not sure about is to how to treat variables without type, > > If there's no type, there's nothing we could infer nullability from. The...

I would like to prepare PR for [phpstan/phpstan-doctrine](https://github.com/phpstan/phpstan-doctrine), so it can read the config ang figure out how to check nullable types, but I don't know if this naming is...

> [88d2d2d](https://github.com/doctrine/orm/commit/88d2d2d331a4939d13beabb40ae8a494d166f672) applies to lower branches as well, right? I think it should go in a separate PR. Ok, I have removed that typo fix from the second half of...

Sorry, I just found one bug, it was adding JoinColumn also on inverse side of OneToOne, fixed. Btw I just tested phpstan/phpstan-doctrine and it works out of the box, because...