tview icon indicating copy to clipboard operation
tview copied to clipboard

added Page.GetPageNames(visible_only bool) API

Open carpii opened this issue 1 year ago • 1 comments

carpii avatar Aug 28 '23 22:08 carpii

Addresses the limitation that there's no way to iterate over pages currently, which is useful for highly dynamic apps (and providing Alt-Tab functionality)

carpii avatar Aug 28 '23 22:08 carpii

This would be great to have. Is there any way to upvote/get this some attention?

Or is the project semi dead or considered feature complete? :(

GiGurra avatar Apr 19 '24 11:04 GiGurra

See https://github.com/rivo/tview/blob/master/CONTRIBUTING.md#pull-requests

But looking at this now, this PR has multiple issues:

  • Using snake case for variable names
  • Using the slices package which requires Go 1.21. We're at Go 1.18 in tview and last time I upgraded the minimum version (and I did so long after Go 1.18 was released), I was showered with tons of complaints because it broke a lot of builds. The slices package has been introduced officially about half a year ago so I would like to wait a bit before bumping the Go version again.
  • Minor but still: "Start all sentences upper-case, as is common in English, and end them with a period." (While you're add it, please wrap lines at a maximum of 80 characters.)

rivo avatar Apr 19 '24 18:04 rivo

Pull request replaced with https://github.com/rivo/tview/pull/971

carpii avatar Apr 19 '24 19:04 carpii

#970 looks good but you closed it...

rivo avatar Apr 19 '24 19:04 rivo

Sorry, I made a bit of a mess of the push

Replaced with #971

carpii avatar Apr 19 '24 19:04 carpii