tview icon indicating copy to clipboard operation
tview copied to clipboard

Published 20 hours ago • verified publisher icon rivo

TextArea

Open Konstantin8105 opened this issue 4 years ago • 9 comments

Create for #64

  • Adding/removing characters
  • Navigating the text
  • Graphemes support
  • Test for finding corner cases
  • Add demos source
  • Minimal change into TextView
  • No color
  • No regions
  • No Form interface

Konstantin8105 avatar May 14 '20 21:05 Konstantin8105

@Konstantin8105 Given the pace at which reviews go in this repo, I'd suggest you move this widget to your own staond-alone repo under your control so we can begin using this and you can get PRs for improvements. I did this with my widget, winman so it would be available immediately to everybody.

jpeletier avatar Jun 01 '20 23:06 jpeletier

@jpeletier In according to LICENSE, you can merge that widget in your project without any link on myself. Feel free to coping, using, and ...

Konstantin8105 avatar Jun 02 '20 09:06 Konstantin8105

@Konstantin8105 Yes, thank you for a permisive license, but I would like to avoid copying your code if I can better link to it and everyone shares the same to improve it together.

This repo is quite "slow". If you keep this in your repo, we can probably evolve your TextArea widget faster together.

jpeletier avatar Jun 02 '20 09:06 jpeletier

This is actually a very very useful addition. Is there any reason it cannot be merged into master. Just trying to get a picture on timeline as this is also what I need.

ghost avatar Oct 25 '20 23:10 ghost

watching this one as well...

buzzdan avatar Dec 30 '20 09:12 buzzdan

This is very useful! I waiting and I hope TextArea added

skanehira avatar Jan 06 '21 23:01 skanehira

Also waiting for merge of this PR.

l13t avatar Jan 07 '21 19:01 l13t

I have been waiting for this future to start a personal project. So I appreciate it if it can be merged asap.

brlbil avatar Mar 13 '21 06:03 brlbil

I know this will be disappointing to some of you but it's unlikely I will merge this PR. There are a whole bunch of reasons but the two major reasons are: I don't think TextArea should be based on TextView because it would inherit all the shortcomings of TextView, mainly its inability to handle large texts as well as its non-optimal performance. The second major reason is that this PR has a bug at its core that will not be trivial to fix: Runes are not Unicode graphemes. A grapheme can consist of multiple runes. (A lot of emojis, e.g. flags, consist of multiple runes.) This will lead to bugs; I've already seen and fixed many related bugs.

Please fill out #578, TextArea is one of the features you can "vote" for. (So far, no one has voted for the text editing component. But there's still time to fill out the questionnaire.) If it comes out on top, it will be one of the next big things I will tackle.

rivo avatar Mar 13 '21 21:03 rivo

TextArea exists now. (Since last year already.)

rivo avatar Aug 26 '23 14:08 rivo