river icon indicating copy to clipboard operation
river copied to clipboard

wofi rendering error

Open TAforever opened this issue 1 year ago • 6 comments

Actually, the problem is in the title. Tested in other wayland compositors and there is no such problem. I am attaching a screenshot. wofi

TAforever avatar Sep 17 '22 16:09 TAforever

Could you provide your wofi configuration? Otherwise there is no way for me to reproduce this.

Leon-Plickat avatar Sep 22 '22 16:09 Leon-Plickat

It's not about configuration. I moved the ~/.config/wofi directory to test. The effect is the same.

TAforever avatar Sep 22 '22 16:09 TAforever

Can you then explain what the rendering error is, so someone who does not use wofi and has no idea how the UI is supposed to look can spot it?

Leon-Plickat avatar Sep 22 '22 16:09 Leon-Plickat

In the first shot taken in hyprland, the wofi has a white border on all sides and the in-focus element does not go outside the window. In the second picture, river. wofi1_grim wofi2_grim

TAforever avatar Sep 22 '22 16:09 TAforever

Even visually, you can see that the window in the river is smaller in height.

TAforever avatar Sep 22 '22 17:09 TAforever

I also noticed that if you run wofi with the --normal-window option, the window is drawn fine, but accordingly, since it has become a normal floating window, window decorations have appeared.

TAforever avatar Sep 22 '22 17:09 TAforever

In both of those screenshots exactly 12 items are visible. I don't see any evidence of a river bug, wofi does seem to have non-deterministic ordering of menu items though.

ifreund avatar Sep 23 '22 02:09 ifreund

Just run it with and without the --normal-window option and you'll see the difference.

TAforever avatar Sep 23 '22 08:09 TAforever

Both look exactly the same on my end, with the sole difference that once has a border drawn by river, as expected.

Leon-Plickat avatar Sep 23 '22 08:09 Leon-Plickat

https://user-images.githubusercontent.com/52626363/191970491-16135ec2-4ad0-4287-8828-6d2e08c84883.mp4

TAforever avatar Sep 23 '22 13:09 TAforever

https://user-images.githubusercontent.com/52626363/191970557-4db4fc02-b6bb-4b96-b887-55249696c6f1.mp4

TAforever avatar Sep 23 '22 13:09 TAforever

https://user-images.githubusercontent.com/52626363/191972691-a0e872e5-2532-48d6-8f69-c7c905eb1a29.mp4

TAforever avatar Sep 23 '22 13:09 TAforever

Ah ok, now I can see it and I definitely can reproduce it. Thanks for the videos.

Leon-Plickat avatar Sep 23 '22 13:09 Leon-Plickat

Ok, so I can only reproduce on the larger of my screens.

Here is the abbreviated WAYLAND_DEBUG output:

[1806177.761]  -> [email protected]_size(50, 40)

[1806178.043] [email protected](34540, 50, 40)
[1806178.052]  -> [email protected]_configure(34540)

[1806184.753]  -> [email protected]_size(1280, 432)
[1806184.794]  -> [email protected]()

[1806184.965] [email protected](34542, 1280, 432)
[1806184.974]  -> [email protected]_configure(34542)

[1806206.270]  -> [email protected](0, 0, 1228, 414)

[1806206.280]  -> [email protected]_region(new id wl_region@36)
[1806206.289]  -> [email protected](0, 0, 1280, 466)
[1806206.298]  -> [email protected]_opaque_region(wl_region@36)

[1806206.313]  -> [email protected]_region(new id wl_region@37)
[1806206.321]  -> [email protected](-10, -10, 1300, 486)
[1806206.330]  -> [email protected]_input_region(wl_region@37)

[1806239.152] [email protected](34543, 1280, 432)
[1806239.162]  -> [email protected]_configure(34543)

Their math w.r.t. surface size seems to be a bit messed up? Smells like a client bug to me. Note that rivers layer shell implementation is stricter than that of sway, so it may expose bugs previously unnoticed.

Leon-Plickat avatar Sep 23 '22 13:09 Leon-Plickat

Today the problem was solved in some magical way for me.

TAforever avatar Oct 20 '22 11:10 TAforever