react-filters icon indicating copy to clipboard operation
react-filters copied to clipboard

fix(proptype): allow array as value for Slider > Control and others...

Open nattatorn-dev opened this issue 7 years ago • 2 comments

allow array as value for Slider > Control allow number as value for Slider > Rail allow number as value for Stories > Container

Fixed WARNING Warning: Failed prop type: Invalid prop value of type array supplied to Control, expected number. Warning: Failed prop type: Invalid prop value of type number supplied to Rail, expected array. Warning: Failed prop type: Invalid prop value supplied to Container. in Container

nattatorn-dev avatar May 03 '17 08:05 nattatorn-dev

Codecov Report

Merging #31 into prop-val will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           prop-val      #31   +/-   ##
=========================================
  Coverage     41.32%   41.32%           
=========================================
  Files            32       32           
  Lines           242      242           
=========================================
  Hits            100      100           
  Misses          142      142
Impacted Files Coverage Δ
components/Slider/Rail.js 25% <ø> (ø) :arrow_up:
components/Slider/Control.js 13.2% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fc89e26...553dfed. Read the comment docs.

codecov-io avatar May 03 '17 09:05 codecov-io

So so sorry for not responding to this PR. Actually I haven't been working on this repo and separated this component into a separate repo https://github.com/ritz078/react-slider

ritz078 avatar Jul 10 '17 18:07 ritz078