ng-embed icon indicating copy to clipboard operation
ng-embed copied to clipboard

Not working?

Open saade opened this issue 8 years ago • 6 comments

The emojis is working fine, links too, but embeds not, any ideas?

image image image

saade avatar Feb 23 '17 15:02 saade

Oh, sorry. I didn't saw the "Its features are limited to converting text into emojis, font smileys and HTML Links." on the filter option.

:)

saade avatar Feb 23 '17 15:02 saade

twitter, youtube and spotify should work.

ritz078 avatar Feb 24 '17 07:02 ritz078

Yes, they are working now. But with millions errors in console, like:

image

saade avatar Feb 24 '17 11:02 saade

You are using angular.element the wrong way, at:

 /**
                             * Adding line numbers to code
                             */
                            $timeout(function () {
                                if (options.code.lineNumbers) {
                                    angular.element('.ne-code').each(function () {

can i send a pull request?

saade avatar Feb 24 '17 11:02 saade

PR is always welcome.

ritz078 avatar Feb 24 '17 11:02 ritz078

If jQuery is loaded there shouldn't be any errors, however it would be better to implement without jQuery as dependency.

robman87 avatar Sep 13 '17 11:09 robman87