Ritesh Kumar
Ritesh Kumar
I created on my own. Hopefully, it can help https://github.com/ritz078/raaga/blob/master/components/Piano.tsx
> I would like to take up this issue. Sure. I have assigned this to you.
Nested ternary operator is never a good idea. Why not simplify the code: ```js var platformOs = platform.os.toString(); var linuxDownloadButton = ( ); var macOSDownloadButton = ( ); var windowsDownloadButton...
> Should I make a PR then? You should have directly opened a PR. We can discuss code changes in the PR. Issue is just for discussing the problem. Not...
Go ahead and open a PR. I will be able to see this in action there.
Oh. See the code again. There's a typo. 😛 ```diff {platformOs.match(/Mac OS/i) && macOSDownloadButton} - {platformOs.match(/Win/i) && macOSDownloadButton} + {platformOs.match(/Win/i) && windowsDownloadButton} {platformOs.match(/Linux/i) && linuxDownloadButton} {githubRepoButton} ``` Line no 3...
> You can assign me this issue. Done
Thanks for the whole stack trace. Can you help me with the steps to reproduce this ?
Nevermind. I was able to reproduce this.
We will need https://github.com/sindresorhus/electron-unhandled/issues/18 to fix this or we can implement the whole logic here. I will prefer the first one since that will help more people. After the filter...