Ritwik Ranjan

Results 27 comments of Ritwik Ranjan

To address the potential misconfiguration of `MetricsInterval`, I agree with @huntergregory about introducing a new field in the YAML configuration, such as `MetricsIntervalDuration`. This new field would take precedence over...

I dig through some recent failures to find out the common causes and came up with following in order of recency --- ### 1 Atleast 2 times and most recent...

Let's triage one by one --- ### For 1 The error is most likely coming from [this](https://github.com/microsoft/retina/blob/5685fdf61c5b0c8875e71e80556f03cdc7b6ab0f/test/e2e/scenarios/dns/scenarios.go#L51C1-L61C5) ```go { Step: &kubernetes.ExecInPod{ PodName: podName, PodNamespace: "kube-system", Command: req.Command, }, Opts: &types.StepOptions{...

Number 6 was already addressed by increasing the timeout from 8 min to 20 min, hence we don't require much there. I have addressed 1,2 & 4 in PR #867

We have fixed all identified flakiness, closing the issue!

Hey @aojea, Can you take a look and let me know if it can be improved in any way?

Hi @aojea, Would you be able to take a look at these changes now?

Okay, sounds good to me, I'll go ahead and split into commits.

Hi @aojea, is there anything else I can do to better this?

@aojea For 1 & 3, I have not found any explicit place where these tests are used directly however I have made sure keep backward compatibility, all the targets in...