Virtual-Assistant icon indicating copy to clipboard operation
Virtual-Assistant copied to clipboard

Some code safety insights

Open B1Z0N opened this issue 2 years ago • 1 comments

Thanks for your contribution to opensource! There's some code safety improvements possible, for example:

  1. scanf return value not taken into account. Possibly here(for example) and in other places.
  2. Unfreed memory and unitialized memory access. Possibly here(for example) and in other places. Please check valgrind tool to mitigate this kind of safety flaws.
  3. Excessive use of system calls without user input validation. Possibly here(for example) and in other places. Please see how it may be abused here.

B1Z0N avatar Dec 23 '22 20:12 B1Z0N