Celestial-bodies-detection icon indicating copy to clipboard operation
Celestial-bodies-detection copied to clipboard

Published 20 hours ago • verified publisher icon ritwik12

Setup CI build Travis

Open ritwik12 opened this issue 5 years ago • 12 comments

It will be good to have travis here

ritwik12 avatar Jan 08 '20 07:01 ritwik12

Would like to work on it.

Satyabrat35 avatar Jan 30 '20 13:01 Satyabrat35

Sure, please send PR @Satyabrat35

ritwik12 avatar Jan 30 '20 13:01 ritwik12

@Satyabrat35 Any progress here?

ritwik12 avatar Feb 04 '20 07:02 ritwik12

I am figuring out the tests for the build. Will write the tests and make a PR in a week.

Satyabrat35 avatar Feb 04 '20 08:02 Satyabrat35

Review #55

Satyabrat35 avatar Feb 05 '20 13:02 Satyabrat35

@Satyabrat35 That is good but it is a basic Travis integration. We need new travis for new PR's code to make sure they will work well once we merge it. For now your tests are only for the already present code in this Repo.

ritwik12 avatar Feb 06 '20 06:02 ritwik12

Let me know if you want to contribute further to this :)

ritwik12 avatar Feb 06 '20 06:02 ritwik12

@Satyabrat35 Please check #57 where it fails. Also, can we add flake8 or something else also to make sure the Code is python only. For eg: I just wrote "Test Travis" in that PR. So as per Python code, it should give error as it's not a variable nor a comment.

ritwik12 avatar Feb 06 '20 06:02 ritwik12

Yeah sure .. will look into #57

Satyabrat35 avatar Feb 06 '20 08:02 Satyabrat35

Review #58 and #57

Satyabrat35 avatar Feb 06 '20 13:02 Satyabrat35

@ritwik12 I would like to take this up and work towards it.

sudhanshu-chauhan avatar Sep 30 '22 16:09 sudhanshu-chauhan

@sudhanshu-chauhan Sure

ritwik12 avatar Oct 13 '22 05:10 ritwik12