Celestial-bodies-detection icon indicating copy to clipboard operation
Celestial-bodies-detection copied to clipboard

Published 20 hours ago • verified publisher icon ritwik12

Irregular galaxy

Open kousikr26 opened this issue 5 years ago • 8 comments

kousikr26 avatar Oct 23 '19 13:10 kousikr26

@kousikr26 Thanks for the PR but this includes some images of comets as well. I guess you are creating branches from other branches only. You should keep a branch clean such as "master" to create as many new branches for all the Different PRs unrelated to each other.

ritwik12 avatar Oct 28 '19 12:10 ritwik12

@ritwik12 sorry about that removed it now and added the necessary code, please review

kousikr26 avatar Oct 28 '19 14:10 kousikr26

@kousikr26 Can you please add few test data also for this?

ritwik12 avatar Nov 04 '19 11:11 ritwik12

@ritwik12 What info should I put in the display_info.yml file for an irregular galaxy as there is no such quantitative data about them. I didn't add anything as there was no entry in it for spiral and elliptical galaxy also.

kousikr26 avatar Nov 04 '19 13:11 kousikr26

@kousikr26 Not needed in that case, we should have an issue for adding display info data for galaxies as well to get more info. I will create it

ritwik12 avatar Nov 04 '19 13:11 ritwik12

@kousikr26 Please add test data.

ritwik12 avatar Nov 04 '19 13:11 ritwik12

@ritwik12 added test data

kousikr26 avatar Nov 05 '19 08:11 kousikr26

@kousikr26 irregular_3.jpg seems doubtful to be real, better remove it. Two images are fine for test data. Also, where did you get the data. Google search or most websites will not be able to identify a spiral, elliptical or irregular galaxy and all pics will be mixed up which I can see in your data. Please manually verify all data is real and irregular galaxy only. Few are elliptical in this.

ritwik12 avatar Nov 05 '19 12:11 ritwik12