vscode-live-server icon indicating copy to clipboard operation
vscode-live-server copied to clipboard

Added chromium support in liveServer.settings.CustomBrowser

Open 0xboz opened this issue 5 years ago • 2 comments

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ x] Feature
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other: <!-- Please describe: -->

What is the current behavior?

I was running vscode with liveserver in Debian 9. My default browser is chromium. When I put chromium or chromium:PrivateMode in liveServer.settings.CustomBrowser, liverserver will use non incognito mode for both.

Issue Number: N/A

What is the new behavior?

Added chromium and chromium:PrivateMode into liveServer.settings.CustomBrowser setting. Basically, the use can use chromium or chromium:PrivateMode without lint error.

Does this PR introduce a breaking change?

[ ] Yes
[ x] No

Other information

Thank you for your time to review my request.

0xboz avatar May 09 '19 21:05 0xboz

Any chance to see this PR merged?

iaeiou avatar Oct 28 '21 21:10 iaeiou

Note that it already works with "liveServer.settings.CustomBrowser": "chromium", on Linux if Chromium is already started

iaeiou avatar Oct 28 '21 21:10 iaeiou