vscode-live-server icon indicating copy to clipboard operation
vscode-live-server copied to clipboard

feat: Live editing with live server

Open rjoydip-zz opened this issue 6 years ago • 11 comments

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other: <!-- Please describe: -->

What is the current behavior?

Not available for the live editing feature.

Issue Number: #119 , #71

What is the new behavior?

Live editing works with liveServer.settings.liveEditing configuration with liveServer.experimental.liveEditing flag.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

This is similar to previous #122 . I will close previous once it is accepted.

rjoydip-zz avatar Jun 09 '18 12:06 rjoydip-zz

Suppose I'm editing Index.html and now I move to foo.html & start typing in vs code but index.html is opened in the browser. In this scenario, the content of foo.html is showing on Index.html page in the browser.

This issue has been fixed. 😃 💥 🎉

rjoydip-zz avatar Jun 09 '18 12:06 rjoydip-zz

Seriously Great! 😃 💥 🎉. This will be shipped by tomorrow. Anyway, before that, I've to update Live Server Web Extension for breaking changes.

ritwickdey avatar Jun 09 '18 13:06 ritwickdey

BTW, why two type of settings?

"liveServer.settings.liveEditing" & "liveServer.experimental.liveEditing". I think, keeping only liveServer.experimental.liveEditing is the better choice.

ritwickdey avatar Jun 09 '18 13:06 ritwickdey

Yes, I was thinking too. Modified please check it.

rjoydip-zz avatar Jun 09 '18 13:06 rjoydip-zz

Is the stylesheet working? I test on my local, it is not working.

ritwickdey avatar Jun 10 '18 05:06 ritwickdey

let me check. Hey, @ritwickdey I found a serious issue on live editing on CSS file. I have to spend more time on this issue

rjoydip-zz avatar Jun 10 '18 05:06 rjoydip-zz

Hi @rjoydip, can you please move the branch to this repo, so that I can also commit when I'll be free. This is the most loveable feature. ❤️ .

ritwickdey avatar Jun 17 '18 07:06 ritwickdey

@ritwickdey Rather I can give you my repo access. You can change here. I don't know how to move a branch. This will be easy to give you access. Is it fine?

rjoydip-zz avatar Jun 17 '18 08:06 rjoydip-zz

Yaa. That's okay.

But it is easy.
git fetch origin pull/ID/head:BRANCHNAME && git checkout BRANCHNAME && git push origin BRANCHNAME -u

Do whatever you want. I've no issue.

ritwickdey avatar Jun 18 '18 12:06 ritwickdey

Okay. I will give you access

rjoydip-zz avatar Jun 18 '18 18:06 rjoydip-zz

@ritwickdey I gave you my repo access. Please check it.

rjoydip-zz avatar Jun 18 '18 18:06 rjoydip-zz