stuntman icon indicating copy to clipboard operation
stuntman copied to clipboard

Update samples

Open stjepan opened this issue 5 years ago • 0 comments

I noticed some of your samples aren't updated/correctly setup. You should update them to at least cover minimum supported target versions, which are .net core 2.1 and .net framework 4.6.1

This is how it looks today and some suggestions:

samples/UsageSample.AspNetCore

  • targets .net core 2.1

samples/UsageSample.BearerTokenTester

  • targets .net 4.5, but should be updated for .net 4.6.1

samples/ServerTester

  • targets .net 4.6.1, but is not correctly configured:
  • App.config change sku to .NETFramework,Version=v4.6.1 <supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.5" />

samples/UsageSample

  • targets .net 4.6.1, but is not correctly configured:
  • Web.config change both targetFramework to 4.6.1 <compilation debug="true" targetFramework="4.5" /> <httpRuntime targetFramework="4.5" />

samples/UsageSampleMvc.AspNetCore

  • targets .net core 2.2

stjepan avatar May 09 '19 13:05 stjepan