Ritik Rawal
Ritik Rawal
``` if (schemaValidationErrors.length) { const errors = schemaValidationErrors; schemaValidationErrors.length = 0; throw new ParserError({ type: validationError, title: 'Channel validation failed', parsedJSON, validationErrors: errors, }); ``` @magicmatatjahu Will using the above...
@derberg @magicmatatjahu I have implemented the requested changes but failed the `npm run test` and I am not able to figure out how I can resolve the TypeErrors I am...
@derberg @magicmatatjahu I have made the requested changes kindly review the PR :)
hi @derberg While implementing the requested changes I am confused about some requested changes like - https://github.com/asyncapi/parser-js/pull/449#discussion_r793922835 (I am sure whether I have implemented it correctly or not) - https://github.com/asyncapi/parser-js/pull/449#discussion_r793945425...
> Then you throw error separately in `customComponentsMsgOperations` and `customChannelsOperations`. Why not throw one aggregated error under `customDocumentOperations` after running custom operations? `type`, `title` and `detail` are always the same,...
Got it 👍
@derberg @magicmatatjahu sorry I was caught up with some college work 😅. I have made some changes kindly review them.🙂
@magicmatatjahu Sorry for the late response. Yes, I do have time to contribute but not as much as I had before 😔. As of now, I will only be able...
Sorry for the delay. I made the changes but didn't forget to push the code. I am still facing some doubts though. Kindly help me out
@derberg Sorry for the miscommunication. I meant I have pushed the code can you review it.😊