Perforce support

[manolkalinov]

Amazingly helpful plugin! It would be awesome if Perforce was supported. A lot of people in corporate offices (such as myself) would use it. Is Perforce support planned?

[ritesh-kapoor]

I have no experience on perforce.But I will try to add in upcoming releases.

[ritesh-kapoor]

@manolkalinov Could you please download pre-release and verify weather you are able to post reviews to perforce server. It uses RBTools to generate diff.

Link: https://github.com/ritesh-kapoor/review-board-idea-plugin/releases/download/v0.1.2-beta.1/review-board-idea-plugin.jar

Go to Reviewboard Settings->Enable Use RBTools Options

Thanks :)

[manolkalinov]

@ritesh-kapoor Here is the first issue I encountered. The icon-button "Publish Review" invokes a confirm dialog which says: "Upload all local changes?". What does this mean? Will it post every local change in every Changelist? It is unclear and I dare not press 'Yes' :), because I have several Changelists and I do not want to post all of them to one review request.

Perforce has the notion of Changelists. So, the Post Review button needs to work on a specific Changelist. Here are several approaches that come to my mind:

1. Have the "Post Review" button enabled when a Changelist is selected, and disabled when nothing is selected.
2. Add the action to the context menu of a Changelist.
3. Upon pressing "Post Review", a popup would display a list of the available Changelists and let the user select one and then press "Post".
4. Post a review of the currently active Changelist.

In any case, the "Post Review" action needs to post a review of just one Changelist, instead of "all local changes".

Let me know what you think.

Best regards, Manol

[rogerdubbs]

For what it's worth, I need this also.

[crukedsh]

#61