verovio icon indicating copy to clipboard operation
verovio copied to clipboard

Published 20 hours ago • verified publisher icon rism-digital

Pedal lines over system break

Open rettinghaus opened this issue 3 years ago • 4 comments

closes #1575 closes #1582

rettinghaus avatar Sep 04 '20 15:09 rettinghaus

A few things before I review this PR:

  • can we have it without all the formatting changes that are un-related? It makes it difficult to review.
  • encoding of pedal lines with simply up and down is quite poor. There was a discussion here a while ago on this topic https://github.com/music-encoding/music-encoding/issues/305. It think it would makes sense to use either @tstamp2/@endid or @next. This would avoid un-resolved cases
  • can we have the images of the desired rendering for #1575?

lpugin avatar Sep 07 '20 07:09 lpugin

Removed the clang-format. Should be run after merge.

rettinghaus avatar Sep 07 '20 08:09 rettinghaus

Since this PR is about the simple cases (down / up) it should implement the @tstamp2(or@endid`) approach recommended here music-encoding/guidelines#138

(We can then treat bounces with the @next as suggested here music-encoding/music-encoding#305)

OK?

lpugin avatar Sep 07 '20 11:09 lpugin

Still, the main goal is to have Ped. glyphs interchangeable with line rendering.

Also, I would expect an encoding with @tstamp2 to produce something similar as with dir or dynam, i.e. pedal preview

But this still is undefined, see https://github.com/music-encoding/music-encoding/issues/644

rettinghaus avatar Sep 07 '20 12:09 rettinghaus

@rettinghaus I am closing it and you can make a fresh PR implementing support for the new MEI attribute.

lpugin avatar Oct 07 '22 06:10 lpugin

The PR had nothing to do with the new pedal-style value. It was about connecting single <pedal> elements, because you cannot have bounces with @tstamp2.

rettinghaus avatar Oct 07 '22 07:10 rettinghaus