muscat
muscat copied to clipboard
Allow different templates for secondary literature
This patch is the second version of the first step towards having different templates for secondary literature. It synchronises some code and configuration files from sources so now, when creating a new record, appears a menu with a single choice, the legacy template.
This version takes into account the catalogues to publications rename and it adds the locale entries compatible with the i18n reorganisation.
There are yet no new fields (like record type) or tag changes.
This patch updates and replaces #1017.
May I do anything to help the approval of this patch?
Sorry! I'm a bit late on this track, I will follow a review shortly!
Everything in the patch seems ok to me, for the moment we can keep then placeholder since they are in the "interface" language file. I only have one question: where do you store the resulting record_type? In Source there is a dedicated field, but I can't find one here.
I only have one question: where do you store the resulting record_type? In Source there is a dedicated field, but I can't find one here.
It's requested in #1028 (I've also put some other requests on hold, because maybe there are better solutions).
ok, for the moment I would add a record_type as you suggest, I can also rename title to description
Could you also add name
to short_name
to this shorter list, please? The reasons are explained in #1027, and I understand that being, as it is, an internal identifier, will not hurt anybody.
Sorry for the silence - I had to take a small detour for other projects, I will add those fields in 7.1 (and in the next dev branch) so we can merge this.
Can I do anything else for this (and my other pending PR) to be included upstream, @xhero? I'm applying those patches to my sites for each new Muscat release, and we are using them daily (although not in production yet). Thanks.