risingwave icon indicating copy to clipboard operation
risingwave copied to clipboard

[draft] feat: Google Pubsub Connector

Open ditsuke opened this issue 2 years ago • 1 comments

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

A connector for Google Cloud Pubsub

***PLEASE DO NOT LEAVE THIS EMPTY !!!***

Please explain **IN DETAIL** what the changes are in this PR and why they are needed:

- Summarize your change (**mandatory**)
- How does this PR work? Need a brief introduction for the changed logic (optional)
- Describe clearly one logical change and avoid lazy messages (optional)
- Describe any limitations of the current code (optional)

Checklist

  • [ ] I have written necessary rustdoc comments
  • [ ] I have added necessary unit tests and integration tests
  • [ ] All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

Types of user-facing changes

  • Connector (sources & sinks)

Release note

@todo

Refer to a related PR or issue link (optional)

@todo

ditsuke avatar Sep 21 '22 09:09 ditsuke

tracked by #4586

tabVersion avatar Sep 22 '22 04:09 tabVersion

rebased to c9dc5b9446985fb28acbed4880726e099b86929b

ditsuke avatar Sep 28 '22 05:09 ditsuke

Codecov Report

Merging #5476 (b7d5a70) into main (2d87383) will decrease coverage by 0.19%. The diff coverage is 64.90%.

@@            Coverage Diff             @@
##             main    #5476      +/-   ##
==========================================
- Coverage   74.07%   73.87%   -0.20%     
==========================================
  Files         989     1002      +13     
  Lines      161850   162541     +691     
==========================================
+ Hits       119888   120077     +189     
- Misses      41962    42464     +502     
Flag Coverage Δ
rust 73.87% <64.90%> (-0.20%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/error.rs 0.00% <ø> (ø)
src/batch/src/executor/mod.rs 74.60% <0.00%> (+2.29%) :arrow_up:
src/common/src/catalog/schema.rs 78.12% <0.00%> (-6.34%) :arrow_down:
src/compute/src/lib.rs 2.56% <ø> (ø)
src/compute/src/server.rs 0.00% <0.00%> (ø)
src/connector/src/source/base.rs 75.00% <0.00%> (-1.67%) :arrow_down:
...ctor/src/source/google_pubsub/enumerator/client.rs 0.00% <0.00%> (ø)
...nnector/src/source/google_pubsub/source/message.rs 0.00% <0.00%> (ø)
...onnector/src/source/google_pubsub/source/reader.rs 0.00% <0.00%> (ø)
src/connector/src/source/google_pubsub/split.rs 0.00% <0.00%> (ø)
... and 111 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 28 '22 08:09 codecov[bot]

rebased to main

ditsuke avatar Oct 06 '22 09:10 ditsuke

please follow https://github.com/risingwavelabs/risingwave/pull/5647 and change the read process to an async stream.

tabVersion avatar Oct 07 '22 09:10 tabVersion

please follow #5647 and change the read process to an async stream.

On it

ditsuke avatar Oct 07 '22 14:10 ditsuke

Rebased to main

ditsuke avatar Oct 08 '22 09:10 ditsuke

please follow #5647 and change the read process to an async stream.

@tabVersion done. please take a look

ditsuke avatar Oct 08 '22 10:10 ditsuke

rebased to 5cb6a1fbfb187effcd411ddf21630d2223fe0815

ditsuke avatar Oct 16 '22 06:10 ditsuke

rebased to 164714f2eee9cd027ee91329530d8aea47ea6366

ditsuke avatar Oct 24 '22 17:10 ditsuke

rebased to 0f026ae09a0634174cac22d479518944fba6a247 with fix from #6095.

ditsuke avatar Oct 28 '22 10:10 ditsuke

rebased to 21e2861087d10aa6cfc1c04c28eaa4ed5145e371

ditsuke avatar Nov 09 '22 19:11 ditsuke

Resolved conflicts, rebased to 29b26e1aec6e53f326c1c8be89dabebe95238f0e

ditsuke avatar Nov 24 '22 13:11 ditsuke

Let's merge it. Great work!

tabVersion avatar Nov 24 '22 15:11 tabVersion