risingwave icon indicating copy to clipboard operation
risingwave copied to clipboard

chore(dev): use playground config for dev

Open nasnoisaac opened this issue 2 years ago • 2 comments

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

use playground config for dev

Checklist

~~- [ ] I have written necessary docs and comments~~ ~~- [ ] I have added necessary unit tests and integration tests~~

  • [x] All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

close #3608

nasnoisaac avatar Jul 03 '22 12:07 nasnoisaac

Codecov Report

Merging #3612 (c448e19) into main (253a648) will decrease coverage by 0.07%. The diff coverage is 47.20%.

@@            Coverage Diff             @@
##             main    #3612      +/-   ##
==========================================
- Coverage   74.30%   74.23%   -0.08%     
==========================================
  Files         773      854      +81     
  Lines      109424   127235   +17811     
==========================================
+ Hits        81304    94448   +13144     
- Misses      28120    32787    +4667     
Flag Coverage Δ
rust 74.23% <47.20%> (-0.08%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/error.rs 0.00% <0.00%> (ø)
src/batch/src/executor/delete.rs 82.25% <0.00%> (+2.57%) :arrow_up:
src/batch/src/executor/filter.rs 71.42% <ø> (-1.03%) :arrow_down:
src/batch/src/executor/hop_window.rs 68.82% <0.00%> (-0.41%) :arrow_down:
src/batch/src/executor/join/hash_join.rs 94.94% <ø> (+10.13%) :arrow_up:
src/batch/src/executor/mod.rs 75.80% <0.00%> (ø)
src/batch/src/executor/project.rs 72.47% <ø> (ø)
src/batch/src/executor/update.rs 83.33% <0.00%> (+1.05%) :arrow_up:
src/batch/src/lib.rs 100.00% <ø> (ø)
src/batch/src/rpc/service/task_service.rs 0.00% <0.00%> (ø)
... and 750 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov[bot] avatar Jul 03 '22 12:07 codecov[bot]

Doesn’t make sense because only meta implements idle timeout. We’ll need to implement idle timeout for other components (or let risedev kill existing components) to make everything work.

skyzh avatar Jul 03 '22 16:07 skyzh