risingwave icon indicating copy to clipboard operation
risingwave copied to clipboard

feat(compaction): introduce auto split and merge policy and config

Open Li0k opened this issue 1 year ago • 4 comments

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  1. refactored and simplified the logic of split policy, support creating table split, and split into two cases
  • high throughput: when the throughput of a state table is greater than threshold in the window, we will try to split the state table into a separate group.
  • huge size: when the size of the group is larger than group max size * ratio, we will try to split the group into two.
  1. support automated merge policy, need to satisfy three conditions:
  • low throughput: when the throughput of all state tables in the group is partially sampled in the window less than threshold.
  • small size: when the sum of the two group sizes is less than group max size * ratio
  • not creating: when none of the tables in the group are creating tables.

we've deprecated some policies (these restrictions were introduced by the previous inability to merge)

  1. split no longer takes state table size into account. In the past, in order to avoid splitting a large number of small groups that cannot be recovered, we would limit the size of non-high throughput tables when attempting a split.
  2. rest_group_size and group_id are no longer considered, only group max size is judged.

Checklist

  • [ ] I have written necessary rustdoc comments
  • [ ] I have added necessary unit tests and integration tests
  • [ ] I have added test labels as necessary. See details.
  • [ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
  • [ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • [ ] All checks passed in ./risedev check (or alias, ./risedev c)
  • [ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • [ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • [ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Li0k avatar Oct 08 '24 09:10 Li0k

  • backfill test https://buildkite.com/risingwave-test/backfill/builds/827#01927044-f790-4aae-ba8c-ffdc3bdadd65

  • longevity-test with High-frequency group scheduling https://buildkite.com/risingwave-test/longevity-test/builds/1899

Li0k avatar Oct 11 '24 10:10 Li0k

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9425213 Triggered Generic Password 604e7a0948e5e119b3e409897aae26bcccf2534b risedev.yml View secret
9425213 Triggered Generic Password 604e7a0948e5e119b3e409897aae26bcccf2534b e2e_test/source_inline/tvf/postgres_query.slt View secret
9425213 Triggered Generic Password 40020891098b629a7efb238a32ede1fd2406aea2 e2e_test/source/tvf/postgres_query.slt View secret
9425213 Triggered Generic Password 40020891098b629a7efb238a32ede1fd2406aea2 e2e_test/source/tvf/postgres_query.slt View secret
9425213 Triggered Generic Password 604e7a0948e5e119b3e409897aae26bcccf2534b e2e_test/source_inline/tvf/postgres_query.slt View secret
9425213 Triggered Generic Password 4fafa58302cd0808ad5a6cf104c9850bf76c3b6d ci/scripts/e2e-source-test.sh View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar Oct 11 '24 11:10 gitguardian[bot]

image

Li0k avatar Oct 16 '24 10:10 Li0k

PTAL @hzxa21 @zwang28

Li0k avatar Oct 21 '24 07:10 Li0k