risingwave icon indicating copy to clipboard operation
risingwave copied to clipboard

refactor(meta): let stream manager handle background ddl recovery instead

Open kwannoel opened this issue 8 months ago • 1 comments

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  1. Let stream manager handle background ddl recovery, so barrier manager doesn't have to maintain recovered stream jobs. That's the role of stream manager.
  2. Move finish_stream_job from DdlController into CatalogManager. This method will take care of committing table catalog. It doesn't make sense to call low level CatalogManager functions inside DdlCatalogManager.

v1 path before: Screenshot 2024-06-21 at 9 05 32 PM

v1 path after: Screenshot 2024-06-21 at 9 05 47 PM

v2 path before: Screenshot 2024-06-21 at 9 06 02 PM

v2 path after: Screenshot 2024-06-24 at 2 23 10 PM

Checklist

  • [ ] I have written necessary rustdoc comments
  • [ ] I have added necessary unit tests and integration tests
  • [ ] I have added test labels as necessary. See details.
  • [ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
  • [ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • [ ] All checks passed in ./risedev check (or alias, ./risedev c)
  • [ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • [ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • [ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

kwannoel avatar Jun 21 '24 12:06 kwannoel