risingwave icon indicating copy to clipboard operation
risingwave copied to clipboard

Deprecate File Source V1

Open fuyufjh opened this issue 9 months ago • 2 comments

The new batch-reading feature was done for v2. https://github.com/risingwavelabs/risingwave/pull/15358

Time to deprecate the old file source.

We can keep the old code for existing users, but the default behavior should be using v2 i.e. No _v2 prefix in s3_v2

fuyufjh avatar May 08 '24 10:05 fuyufjh

https://github.com/risingwavelabs/risingwave/issues/16234

I once created a similar issue.

neverchanje avatar May 08 '24 11:05 neverchanje

#16234 was closed by #16337.

We can keep the old code for existing users, but the default behavior should be using v2 i.e. No _v2 prefix in s3_v2

So, can we do this?

fuyufjh avatar May 13 '24 08:05 fuyufjh

#16234 was closed by #16337.

We can keep the old code for existing users, but the default behavior should be using v2 i.e. No _v2 prefix in s3_v2

So, can we do this?

Yes, not a big deal. Which version should it be? & We can just do the conversion in the frontend, keeping the connector name as s3_v2 in both meta and CN.

tabVersion avatar Jul 10 '24 10:07 tabVersion