risingwave
risingwave copied to clipboard
test: add `single-node` binary tests
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Also tests sqlbackend, since that's used by single-node mode.
Checklist
- [ ] I have written necessary rustdoc comments
- [ ] I have added necessary unit tests and integration tests
- [ ] I have added test labels as necessary. See details.
- [ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
- [ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
- [ ] All checks passed in
./risedev check
(or alias,./risedev c
) - [ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
- [ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)
Documentation
- [ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.
Encounters stack overflow
error.
Ready for review.
Hi @yezizp2012, looks like the tests are failing, could you PTAL? Thanks!
cc @huangjw806, only after this is merged in, then we should cut a new release for 1.7.0-standalone.
Here's my local errors when starting it:
cargo build --bin risingwave
./target/debug/risingwave
log
2024-02-28T23:34:08.04622+08:00 INFO rw-main risingwave_common::telemetry::report: start telemetry reporting
thread 'rw-main' panicked at src/meta/src/barrier/recovery.rs:348:14:
clean dirty streaming jobs: Query Error: error returned from database: (code: 1) no such column: sink.target_table
Backtrace:
Hi @yezizp2012, looks like the tests are failing, could you PTAL? Thanks!
Looks like the single node test passed in the ci workflow?
Here's my local errors when starting it:
cargo build --bin risingwave ./target/debug/risingwave
log
2024-02-28T23:34:08.04622+08:00 INFO rw-main risingwave_common::telemetry::report: start telemetry reporting thread 'rw-main' panicked at src/meta/src/barrier/recovery.rs:348:14: clean dirty streaming jobs: Query Error: error returned from database: (code: 1) no such column: sink.target_table Backtrace:
It should be because you switched branches locally and ran different binaries but forgot to clean up the SQLite file. The old SQLite file was probably generated on a branch without the sink into table feature, while the release-1.7.0-standalone
branch includes it.
Hi @yezizp2012, looks like the tests are failing, could you PTAL? Thanks!
Looks like the single node test passed in the ci workflow?
Here's my local errors when starting it:
cargo build --bin risingwave ./target/debug/risingwave
log
2024-02-28T23:34:08.04622+08:00 INFO rw-main risingwave_common::telemetry::report: start telemetry reporting thread 'rw-main' panicked at src/meta/src/barrier/recovery.rs:348:14: clean dirty streaming jobs: Query Error: error returned from database: (code: 1) no such column: sink.target_table Backtrace:
It should be because you switched branches locally and ran different binaries but forgot to clean up the SQLite file. The old SQLite file was probably generated on a branch without the sink into table feature, while the
release-1.7.0-standalone
branch includes it.
Yes, now it works for me. Thanks!