risingwave icon indicating copy to clipboard operation
risingwave copied to clipboard

feat: report stream error for create streaming jobs

Open yezizp2012 opened this issue 1 year ago • 6 comments

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Resolve #11374 , related #15179 .

Checklist

  • [ ] I have written necessary rustdoc comments
  • [ ] I have added necessary unit tests and integration tests
  • [ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
  • [ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • [ ] All checks passed in ./risedev check (or alias, ./risedev c)
  • [ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • [ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • [ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

yezizp2012 avatar Oct 27 '23 08:10 yezizp2012

May I ask is this related to https://github.com/risingwavelabs/risingwave/issues/12996#issuecomment-1774425756?

BugenZhao avatar Nov 01 '23 03:11 BugenZhao

May I ask is this related to #12996 (comment)?

Yes, it is. And I tried to maintain a mechanism in local barrier manager to distinguish the root cause error, but failed. 🥵 Any ideas?

yezizp2012 avatar Nov 01 '23 03:11 yezizp2012

Do we have some test scenarios for it?

May I ask is this related to #12996 (comment)?

Yes, it is. And I tried to maintain a mechanism in local barrier manager to distinguish the root cause error, but failed. 🥵 Any ideas?

Can we:

  1. Collect all errors.
  2. Ignore internal channel errors

Is that sufficient? It may not cover all propagated errors, but I think it's most common.

https://github.com/risingwavelabs/risingwave/issues/12996#issuecomment-1788410947

kwannoel avatar Nov 01 '23 05:11 kwannoel

Do we have some test scenarios for it?

May I ask is this related to #12996 (comment)?

Yes, it is. And I tried to maintain a mechanism in local barrier manager to distinguish the root cause error, but failed. 🥵 Any ideas?

Can we:

  1. Collect all errors.
  2. Ignore internal channel errors

Is that sufficient? It may not cover all propagated errors, but I think it's most common.

#12996 (comment)

Yes, that's exactly what I tried. see https://github.com/risingwavelabs/risingwave/issues/12996#issuecomment-1788429298

yezizp2012 avatar Nov 01 '23 05:11 yezizp2012

This PR has been open for 60 days with no activity. Could you please update the status? Feel free to ping a reviewer if you are waiting for review.

github-actions[bot] avatar Jan 03 '24 01:01 github-actions[bot]

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9425213 Triggered Generic Password ee60ab8a272e7136faaee9dffe67311983ad283f ci/scripts/regress-test.sh View secret
9425213 Triggered Generic Password ee60ab8a272e7136faaee9dffe67311983ad283f ci/scripts/e2e-source-test.sh View secret
9425213 Triggered Generic Password ee60ab8a272e7136faaee9dffe67311983ad283f ci/scripts/e2e-source-test.sh View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

gitguardian[bot] avatar Feb 22 '24 08:02 gitguardian[bot]