risinglight icon indicating copy to clipboard operation
risinglight copied to clipboard

chore: add github codespace devcontainer configuration

Open yeya24 opened this issue 3 years ago • 4 comments

This PR adds support for setting up the dev environment for Risinglight with Github Codespace. https://docs.github.com/en/codespaces

yeya24 avatar Aug 06 '22 18:08 yeya24

Thanks for this PR! But I doubt whether this is necessary. Do you mainly develop RisingLight on GitHub Codespace?

skyzh avatar Aug 09 '22 13:08 skyzh

This comes in handy sometimes to start a dev environment for Rust and Risinglight to read/write the code. But it is not as good as the local environment due to the resource limitation, which makes it takes a long time to compile the code.

I think it is a good compliment because it gives you an out-of-box environment with the required deps. For beginners like me this is already very useful to try the project.

yeya24 avatar Aug 09 '22 19:08 yeya24

That's cool.

  • I don't think it's good to use zsh here. We should keep the environment as simple as possible.
  • Should install the Rust version of rust-toolchain file in RisingLight repo, instead of just specifying nightly toolchain.

skyzh avatar Aug 09 '22 20:08 skyzh

Thanks. I have updated the PR, please take a look.

yeya24 avatar Aug 13 '22 03:08 yeya24