Rishipal Singh Bhatia

Results 28 comments of Rishipal Singh Bhatia

I would expect the polyfill for `Set` to pull-in `Symbol.iterator` since it has `'require es6/symbol';`. But, Firefox < 36 does not support `Symbol.iterator`.

This isn't merged yet. I'm testing this internally and will update soon.

I'm seeing multiple internal targets failing to build with this error message - 'The import java.util.regex cannot be resolved'.

I'll take another stab at this today and repro+debug the failing tests.

The 'The import java.util.regex cannot be resolved' failures get fixed after switching to re2j regex library. However, I see multiple Scanner tests failing with that. I will update shortly.

Update: I tested this again over the weekend. The internal tests are passing now. I will commit this internally.

Hi, this is not merged yet. A comment from John on the pending CL suggests that this may not be needed after we stopped support for GWT/J2CL version of the...

The Scanner test failures did not get fully resolved contrary to my https://github.com/google/closure-compiler/pull/3647#issuecomment-779989990. This PR is decided to be deprioritized and shelved.

I think that the `MediaQueryListEvent` should've been defined inside `https://github.com/google/closure-compiler/blob/master/externs/browser/w3c_css.js`, but I see that it isn't. Were you able to check that adding it to `w3c_css.js` fixes it?

Update: The fix for this caused runtime errors in a few internal tests. WIP fixing.