github-profilinator icon indicating copy to clipboard operation
github-profilinator copied to clipboard

change icons based on github theme

Open rohanprasadofficial opened this issue 4 years ago • 2 comments

Is your feature request related to a problem? Please describe. As we know Github released their dark mode recently and many icons are not visible now properly.

Describe the solution you'd like We need to add more icons like light foreground for dark bg and dark foreground for light bg and render based on the theme. We can detect the GitHub theme based on the tag on the page of the index.

html lang="en" data-color-mode="dark" This is a dark mode.

html lang="en" data-color-mode="light" This is the light mode.  

rohanprasadofficial avatar Dec 15 '20 13:12 rohanprasadofficial

I guess we'll need JS to detect the color mode and GitHub MD does now allow that.

rishavanand avatar Dec 24 '20 21:12 rishavanand