Rishabh Choudhary

Results 21 comments of Rishabh Choudhary

@droctothorpe done ,i fixed the syntex error.

@droctothorpe I think tke LGTM is required to merge this pr. Bot removed the label due to the new commit of syntex error fix . And Thanks for reviewing my...

Hey @realshuting! I implemented the CI optimizations you suggested in issue #14290. Could you review the changes and let me know if there anything else needed or any adjustments required?...

@aerosouund Would you be able to review this PR when you get a chance?

hey @aerosouund would you take a look on this pr ?

@aerosouund Added chainsaw test for MutatingPolicy with mutateExisting and targets. This covers both the ClusterPolicy case from the previous commit and the MutatingPolicy scenario as requested.

@aerosouund Thanks for pointing me to the MutatingPolicy API. I added a new chainsaw test for MutatingPolicy. I haven’t removed the existing Policy-based chainsaw test, since the older Policy API...

Hey @aerosouund, all set. The MutatingPolicy chainsaw test is now working as expected and verifies that the trigger resource remains unchanged while the background controller mutates the targets. If you...

Hey @aerosouund have a look , all the tests are passing as expected , i successfully added the test steps you suggested.

@aerosouund The issue was that when a mutatingpolicy with mutateexisting was triggered, the admission controller start a background goroutine to create updaterequest but it was using the admission requests context....