gridsome-plugin-pwa
gridsome-plugin-pwa copied to clipboard
rishabh3112
Bug: msapplication head meta tags read as options and result as undefined
There is a bit of code that sets head meta tags for msapplication by reading options
But the dont get exposed publicly, can't be set and don't have defaults
which results in undefined values being output
@chorijan would you like to provide default options for them in a PR ?
And these properties should work if you supply those properties in your project's gridsome.config.js.
@rishabh3112 I did supply the options in my gridsome.config.js in the end, but that resulted with them still being undefined. I then tried also adding them to my main.js (push the head meta tags) which did end up adding them, but also left the previous two undefined(each meta tag was present twice)
@rishabh3112 updated to the latest version and it does seem to create the props now, but there are duplicates as well - like I manually created them which i haven't (the only one i have manually created was the theme-color meta tag)
@chorijan I have tried locally and is working as expected. Please create a minimum reproducible repository for further investigation.
Similar issue: I couldn't access msTileImage from PWA options.
I noticed that the path to icon is generated using icon value in Manifest Options, but then adds -144x144.png, which result in the wrong path /assets/static/favicon.png-144x144.png (first .png is incorrect)
Unfortunately, plugin checks if the favicon exists, so I can't place a random icon value, e.g. icon: 'favicon', to generate correct path.
Wrong path to favicon:
