riscv-fesvr icon indicating copy to clipboard operation
riscv-fesvr copied to clipboard

ignore arguments that start with +

Open colinschmidt opened this issue 7 years ago • 2 comments

This causes htif to skip unknown arguments that start with +.

Other arguments that start with - will still issue stderr messages but not stop option parsing.

This is an improvement on current handling where htif will silently treat unknown arguments that start with + as target arguments.

Open to suggestions but this is a strawman for handling https://github.com/freechipsproject/rocket-chip/issues/1194

colinschmidt avatar Jan 16 '18 18:01 colinschmidt

@seldridge does this make sense with https://github.com/freechipsproject/rocket-chip/pull/1192?

mwachs5 avatar Jan 18 '18 16:01 mwachs5

Yes, they should be mutually exclusive as HTIF argument parsing happens after emulator.cc argument parsing. The PlusArg PR (freechipsproject/rocket-chip#1192) effectively only generates your plusarg struct and the help text based on Chisel code. So, if this PR works with rocket-chip master then the freechipsproject/rocket-chip#1192 shouldn't be an incompatible approach.

Famous last words, however, as I keep delaying testing this with VCS (it's a pain for a variety of reasons...) and there are no regressions that bang on these specific plus args...

seldridge avatar Jan 18 '18 16:01 seldridge