sail-riscv icon indicating copy to clipboard operation
sail-riscv copied to clipboard

Add Zilsd/Zclsd Support

Open trdthg opened this issue 9 months ago • 6 comments

spec: https://github.com/riscv/riscv-zilsd/blob/main/zilsd.adoc#insns-sd

function clause extensionEnabled(Ext_Zclsd) = true & xxx is a placeholder, waiting for config system

trdthg avatar Mar 04 '25 08:03 trdthg

Test Results

398 tests  ±0   398 ✅ ±0   1m 45s ⏱️ ±0s   1 suites ±0     0 💤 ±0    1 files   ±0     0 ❌ ±0 

Results for commit 179b3be3. ± Comparison against base commit 513a7055.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Mar 04 '25 08:03 github-actions[bot]

how does this relate to https://github.com/riscv/sail-riscv/pull/490?

christian-herber-nxp avatar Mar 07 '25 16:03 christian-herber-nxp

how does this relate to #490?

I didn't see it before. Currently, the code mainly has the following differences

  • zcmlsd -> zclsd
  • directly concat the 0 at the end of the imm to the ast
  • ast naming inconsistency (adopted theirs, I haven't added co-authored-by yet because I don't know his email)
  • simply execute
  • TODO some refactor based on the new features of sail
    • [x] #768
    • [x] #758

trdthg avatar Mar 10 '25 01:03 trdthg

@trdthg Could you check with @christian-herber-nxp to make sure we're not missing anything from #490 and we get the appropriate co-authors?

pmundkur avatar Mar 10 '25 15:03 pmundkur

the author of the original PR should be clear from that, it is @simonacostinescu

christian-herber-nxp avatar Mar 10 '25 17:03 christian-herber-nxp

Update

I am trying to run act tests (there is already a PR, not merged yet), but encountered a few problems

  • riscv-config https://github.com/riscv-software-src/riscv-config/pull/189 waiting for merge
  • [x] ~the tests have some issue(seems about ISA constrains), I'm doing some fix~ done
  • [x] gcc zilsd/zclsd support not merged yet(and it's not complete, some orgs have complete version, but lack maintenance, need rebase), trying with clang / compile gcc locally

I think you could review this after I finished those tests.

Co-authored-by already added

trdthg avatar Mar 24 '25 02:03 trdthg