sail-riscv
sail-riscv copied to clipboard
Add Zilsd/Zclsd Support
spec: https://github.com/riscv/riscv-zilsd/blob/main/zilsd.adoc#insns-sd
- zilsd:
- RV32 only
- load/store 64 bit value
- has same assembly with 2.6. Load and Store Instructions
- zclsd:
- RV32 only
- load/store 64 bit value
- has same assembly with 26.3. Load and Store Instructions
- compressed
- base = rs1 or stack_pointer
- has overlapping encodings with Zcf
function clause extensionEnabled(Ext_Zclsd) = true & xxx is a placeholder, waiting for config system
Test Results
398 tests ±0 398 ✅ ±0 1m 45s ⏱️ ±0s 1 suites ±0 0 💤 ±0 1 files ±0 0 ❌ ±0
Results for commit 179b3be3. ± Comparison against base commit 513a7055.
:recycle: This comment has been updated with latest results.
how does this relate to https://github.com/riscv/sail-riscv/pull/490?
how does this relate to #490?
I didn't see it before. Currently, the code mainly has the following differences
- zcmlsd -> zclsd
- directly concat the 0 at the end of the imm to the ast
- ast naming inconsistency (adopted theirs, I haven't added co-authored-by yet because I don't know his email)
- simply
execute - TODO some refactor based on the new features of sail
- [x] #768
- [x] #758
@trdthg Could you check with @christian-herber-nxp to make sure we're not missing anything from #490 and we get the appropriate co-authors?
the author of the original PR should be clear from that, it is @simonacostinescu
Update
I am trying to run act tests (there is already a PR, not merged yet), but encountered a few problems
- riscv-config https://github.com/riscv-software-src/riscv-config/pull/189 waiting for merge
- [x] ~the tests have some issue(seems about ISA constrains), I'm doing some fix~ done
- [x] gcc zilsd/zclsd support not merged yet(and it's not complete, some orgs have complete version, but lack maintenance, need rebase), trying with clang / compile gcc locally
I think you could review this after I finished those tests.
Co-authored-by already added