sail-riscv icon indicating copy to clipboard operation
sail-riscv copied to clipboard

Add Zicfilp extension

Open ved-rivos opened this issue 1 year ago • 4 comments

Specification: https://github.com/riscv/riscv-cfi/blob/main/cfi_forward.adoc Tests: https://github.com/riscv-non-isa/riscv-arch-test/pull/413

ved-rivos avatar Nov 28 '23 02:11 ved-rivos

It should not take 15 commits like that to add this extension. Please condense into a sensible history.

jrtc27 avatar Nov 28 '23 03:11 jrtc27

It should not take 15 commits like that to add this extension. Please condense into a sensible history.

The part that Jessica didn't make explicit is: we use a "rebase and merge" strategy and don't squash your history when merging, so your history should be considered part of the submission.

ptomsich avatar Nov 28 '23 12:11 ptomsich

It should not take 15 commits like that to add this extension. Please condense into a sensible history.

Sorry, that the commit history was nonsense. I have squashed some of the commits. Let me know if it makes sense now.

ved-rivos avatar Nov 28 '23 12:11 ved-rivos

Test Results

712 tests  ±0   712 :white_check_mark: ±0   0s :stopwatch: ±0s   6 suites ±0     0 :zzz: ±0    1 files   ±0     0 :x: ±0 

Results for commit 1056a624. ± Comparison against base commit 40ed0c5b.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Mar 29 '24 18:03 github-actions[bot]