riscv-openocd icon indicating copy to clipboard operation
riscv-openocd copied to clipboard

ch347 usb2jtag driver integrated + Quad SPI Driver for Riscduino SOC …

Open dineshannayya opened this issue 1 year ago • 4 comments

I have Integrated following functionality

  1. src/jtag/drivers/ch347.c : USB To JTAG CH347 Driver : https://www.wch-ic.com/products/CH347.html
  2. src/flash/nor/rqspi.c : Quad SPI Driver for Riscduino SOC These driver needed for following RISCV SOC platform Single 32 Bit RISCV Core: https://github.com/riscduino/riscduino Dual 32 Bit RISCV Core: https://github.com/riscduino/riscduino_dcore Quad 32 RISCV Core: https://github.com/riscduino/riscduino_qcore

Let me know any additional information needed.

dineshannayya avatar Jun 30 '24 09:06 dineshannayya

Should changes like this, not involving any files in the src/target/riscv directory, maybe be done in the upstream OpenOCD project and then back ported from there?

TommyMurphyTM1234 avatar Jun 30 '24 10:06 TommyMurphyTM1234

Should changes like this, not involving any files in the src/target/riscv directory, maybe be done in the upstream OpenOCD project and then back ported from there?

Actually, was this already added upstream:

  • https://sourceforge.net/p/openocd/mailman/search/?q=ch347

and, as such, should probably be integrated from there via a PR like this:

  • https://github.com/riscv-collab/riscv-openocd/pull/1094

Or am I missing something here?

TommyMurphyTM1234 avatar Jun 30 '24 12:06 TommyMurphyTM1234

@TommyMurphyTM1234 Not clear with your response, Do you want me push these changes into https://github.com/en-sc/riscv-openocd.git Repo first ?

dineshannayya avatar Jun 30 '24 12:06 dineshannayya

@TommyMurphyTM1234 Not clear with your response, Do you want me push these changes into https://github.com/en-sc/riscv-openocd.git Repo first ?

No - I never mentioned that repo.

What I'm wondering is...

  1. If these changes were already made upstream (https://openocd.org/pages/repos.html) in which case maybe they should be integrated here in the riscv-openocd via a PR such as this: https://github.com/riscv-collab/riscv-openocd/pull/1094
  2. Assuming that these changes have NOT been made upstream already then maybe that's where they should be done since they are not RISC-V specific (i.e. don't touch any files in src/target/riscv)?

Others such as @en-sc might be able to comment?

TommyMurphyTM1234 avatar Jun 30 '24 13:06 TommyMurphyTM1234

Closing this stale pull request as there has not been any development for the past 2 months.

JanMatCodasip avatar Sep 03 '24 05:09 JanMatCodasip