riscv-openocd icon indicating copy to clipboard operation
riscv-openocd copied to clipboard

target/riscv: avoid unnecesary IR scans

Open en-sc opened this issue 1 year ago • 1 comments

en-sc avatar Jun 14 '24 10:06 en-sc

I have checked the change in select_dmi() visually and it looks all right to me. It is equivalent to what majority (or all?) other targets do.

I can see this PR is still marked as a draft. @en-sc, do you have any doubts about this one or any further testing that you'd like to carry out?

(Also the PR needs to be rebased.)

JanMatCodasip avatar Jul 02 '24 07:07 JanMatCodasip

@JanMatCodasip, I've tested the commit and it seems fine. Please, take a look.

en-sc avatar Sep 06 '24 13:09 en-sc

This commit introduces an issue for targets with IRLEN >= 8 (the issue is not in the commit itself, but in buf_cmp()). The fix is being merged to mainline OpenOCD (huge thanks to @jrtc27): https://review.openocd.org/c/openocd/+/8489

en-sc avatar Sep 13 '24 09:09 en-sc