riscv-isa-manual icon indicating copy to clipboard operation
riscv-isa-manual copied to clipboard

Published 20 hours ago • verified publisher icon riscv

Fix duplication of zbkb, zbkc, zbkx.

Open wmat opened this issue 10 months ago • 3 comments

With the recent integration of numerous ratified specs, some content is duplicated. In particular, the zbkb, zbkc, znc zbkx extensions and the applicable instructions are defined in the Bitmanip chapter as well as the Crypto Scalar chapter.

Should this be the case? If not, where should the content live?

wmat avatar Mar 27 '24 11:03 wmat

Perhaps it would be sufficient to augment the table in unpriv ch28.4 with the zbk* extensions.

aamartin0000 avatar Apr 01 '24 18:04 aamartin0000

Perhaps it would be sufficient to augment the table in unpriv ch28.4 with the zbk* extensions.

Augment in what way? Are you suggesting just referencing the Zbk* definitions in ch33.3?

wmat avatar Apr 02 '24 19:04 wmat

The table in Ch28.4 should have the unique instructions from Zbk* added, and then columns added for Zbkb/Zbkc/Zbkx. Overlapping instructions would have checkmarks in two columns, for example clmul would have checkmarks in both Zbc and Zbkc.

The Zbk* definitions in Ch33.3 are redundant with the definitions in Ch28.4. One of those places should be changed to refer to the other.

aamartin0000 avatar Apr 02 '24 20:04 aamartin0000